Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When uploading a plugin, make sure files starting with a dot are unzipped #11716

Open
tsteur opened this issue May 17, 2017 · 3 comments
Open

When uploading a plugin, make sure files starting with a dot are unzipped #11716

tsteur opened this issue May 17, 2017 · 3 comments
Labels
Bug For errors / faults / flaws / inconsistencies etc.
Milestone
For Prioritization

Comments

@tsteur
Copy link
Member

tsteur commented May 17, 2017

I uploaded a plugin before in Piwik 3.0.4 and noticed a .htacces file was not in the plugin directory after installing it even though it was included in the zip.

We need to try and reproduce this again and if needed fix it.
@tsteur tsteur added the Bug For errors / faults / flaws / inconsistencies etc. label May 17, 2017
@tsteur tsteur added this to the 3.0.5 milestone May 17, 2017
@sgiehl
Copy link
Member

sgiehl commented May 18, 2017

According to various reports on the internet ZipArchive::extractTo is not able to extract hidden files on linux.
Wouldn't it be a possibility to create the file up on install of the plugin within the PHP code?

@tsteur
Copy link
Member Author

tsteur commented May 19, 2017

creating it now on install and activate. Will also be needed to be done on plugin update which I still need to add. If it is not possible to fix we need to document it somewhere I reckon

@mattab
Copy link
Member

mattab commented Jul 24, 2017

maybe we should move to a pure php solution which would let us extract all files? eg https://stackoverflow.com/a/43016122

@mattab mattab modified the milestones: 3.1.0, 3.0.5 Jul 24, 2017
@mattab mattab removed this from the 3.3.0 milestone Oct 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug For errors / faults / flaws / inconsistencies etc.
Projects
None yet
Milestone
For Prioritization
Development

No branches or pull requests
4 participants
@tsteur @mattab @sgiehl @innocraft-automation