Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests CI: ApiCounterTest fails around midnight UTC #11709

Closed
mattab opened this issue May 16, 2017 · 1 comment
Closed

Tests CI: ApiCounterTest fails around midnight UTC #11709

mattab opened this issue May 16, 2017 · 1 comment
Labels
c: Tests & QA For issues related to automated tests or making it easier to QA & test issues. not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.

Comments

@mattab
Copy link
Member

mattab commented May 16, 2017

Around midnight UTC, one of the system tests fails due to a race condition of some sort.

Example failing test: https://travis-ci.org/piwik/piwik/jobs/232632981

Output:

1) Piwik\Plugins\Live\tests\System\ApiCounterTest::test_GetCounters_ShouldOnlyReturnResultsOfLastMinutes
Failed asserting that two arrays are equal.
--- Expected
+++ Actual
@@ @@
 Array (
     0 => Array (
-        'visits' => 24
-        'actions' => 60
-        'visitors' => 20
-        'visitsConverted' => 40
+        'visits' => '27'
+        'actions' => '60'
+        'visitors' => '20'
+        'visitsConverted' => '40'
     )
 )
/home/travis/build/piwik/piwik/plugins/Live/tests/System/ApiCounterTest.php:67
2) Piwik\Plugins\Live\tests\System\ApiCounterTest::test_GetCounters_ShouldHideSomeColumnsIfRequested
Failed asserting that two arrays are equal.
--- Expected
+++ Actual
@@ @@
 Array (
     0 => Array (
-        'visits' => 24
-        'actions' => 60
+        'visits' => '27'
+        'actions' => '60'
     )
 )
/home/travis/build/piwik/piwik/plugins/Live/tests/System/ApiCounterTest.php:83
3) Piwik\Plugins\Live\tests\System\ApiCounterTest::test_GetCounters_ShouldShowAllColumnsIfRequested
Failed asserting that two arrays are equal.
--- Expected
+++ Actual
@@ @@
 Array (
     0 => Array (
-        'visits' => 24
-        'actions' => 60
-        'visitors' => 20
-        'visitsConverted' => 40
+        'visits' => '27'
+        'actions' => '60'
+        'visitors' => '20'
+        'visitsConverted' => '40'
     )
 )
/home/travis/build/piwik/piwik/plugins/Live/tests/System/ApiCounterTest.php:90
4) Piwik\Plugins\Live\tests\System\ApiCounterTest::test_GetCounters_ShouldShowSomeColumnsIfRequested
Failed asserting that two arrays are equal.
--- Expected
+++ Actual
@@ @@
 Array (
     0 => Array (
-        'visits' => 24
-        'actions' => 60
+        'visits' => '27'
+        'actions' => '60'
     )
 )
/home/travis/build/piwik/piwik/plugins/Live/tests/System/ApiCounterTest.php:96
5) Piwik\Plugins\Live\tests\System\ApiCounterTest::test_GetCounters_ShouldHideColumnIfGivenInShowAndHide
Failed asserting that two arrays are equal.
--- Expected
+++ Actual
@@ @@
 Array (
     0 => Array (
-        'visits' => 24
+        'visits' => '27'
     )
 )
/home/travis/build/piwik/piwik/plugins/Live/tests/System/ApiCounterTest.php:102
@mattab mattab added c: Tests & QA For issues related to automated tests or making it easier to QA & test issues. not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. labels May 16, 2017
@mattab
Copy link
Member Author

mattab commented Jun 18, 2019 •
edited

Probably it doesn't occur anymore.

@mattab mattab closed this as completed Jun 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: Tests & QA For issues related to automated tests or making it easier to QA & test issues. not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mattab