Add support for email and url form fields #11708
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsteur
added
c: Platform
sgiehl
reviewed
May 16, 2017
| @@ -148,7 +148,7 @@ | |||
|
|
|||
| function getTemplate(field) { | |||
| var control = field.uiControl; | |||
| if (control === 'password') { | |||
| if (control === 'password' || control === 'url' || control === 'search' || control === 'email') { | |||
There was a problem hiding this comment.
any reason for adding search here but not mentioning it in the changelog and adding a field constant?
There was a problem hiding this comment.
Yes, it is not shown nicely in the UI. I would presume some materialize issue. I'm supporting it technically but not mentioning it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
email and url form fields can now be used in settings or as regular form fields (I'm not sure if they are actually API)