Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

On mobile, show row actions on click #11702

Merged
merged 1 commit into from May 16, 2017
Merged

On mobile, show row actions on click #11702

merged 1 commit into from May 16, 2017

Conversation

tsteur
Copy link
Member

@tsteur tsteur commented May 15, 2017

As mentioned in #10645 the row actions are never visible on mobile. Proposed change will show the row actions when clicking on a column and hide it again on another click. Sometimes it seems to not 100% hide it again but in general should work.

It's better than not being able to show them at all

Can also merge it in other milestone

@tsteur tsteur added c: Design / UI For issues that impact Matomo's user interface or the design overall. Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc. labels May 15, 2017
@tsteur tsteur added this to the 3.0.4 milestone May 15, 2017
if ($(this).hasClass('label')) {
return;
}
$('td', domElem).hover(function() {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here actually nothing changed, reformatted code a little and made a variable re-usable.

}
},
function () {
var useTouchEvent = false;
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here is the actual change. It's a simple detection for mobile devices and if so, we listen to a click event and to show / hide row actions

@mattab
Copy link
Member

mattab commented May 16, 2017

Great idea and will make Piwik more useful on mobile 💯

Will test after merging.

@mattab mattab merged commit 7ab5388 into 3.x-dev May 16, 2017
@mattab mattab deleted the 10645 branch May 16, 2017 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: Design / UI For issues that impact Matomo's user interface or the design overall. Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants