Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release Piwik 3.0.4-rc1 #11699

Merged
merged 23 commits into from May 15, 2017
Merged

Release Piwik 3.0.4-rc1 #11699

merged 23 commits into from May 15, 2017

Conversation

mattab
Copy link
Member

@mattab mattab commented May 15, 2017

tsteur and others added 23 commits May 9, 2017 14:01
I noticed a bug when a plugin requires another plugin.

If eg a plugin named `Acc` requires a plugin named `Cli`, plugin `Acc` will be not activated because `Acc` will be always loaded before `Cli`. See https://github.com/piwik/piwik/blob/3.0.4-b2/core/Application/Kernel/PluginList.php#L113-L114 we always sort custom plugins alphabetically. However, it should respect a required plugin and make sure to load a required plugin first. In this case `Cli` before `Acc`.

In #11676 I implemented similar solution but is slower I would say. This solution should be quite a bit faster when having a few plugins installed.

@sgiehl @mattab maybe you guys have a better idea on how to fix it?

There is still an issue that `plugins/$pluginName/config/config.php` in each plugin is loaded alphabetically. It is to be discussed if a `config.php` of a required plugin should have less of a priority so that a plugin that requires another plugin, can overwrite a DI setting of the required plugin. Meaning ideally, the config for `Cli` would be loaded first, then `Acc` because `Acc` requires `Cli`. This way `Acc` could overwrite any DI setting from `Cli`. Currently, `config.php` files are loaded as they are defined in `config.ini.php` which is usually alphabetically because of https://github.com/piwik/piwik/blob/3.0.4-b2/core/Plugin/Manager.php#L209-L212 (if config file is writable and not changed manually).
Make sure required plugins are loaded in correct order
By specifying an option like `--filter-plugin="Core"` it will only list plugin names that contain the filter / search term.

This is useful when you have many plugins installed or when you want to do a simple check if a plugin is installed or not etc.
* Adds MarketingCampaignsReporting as submodule

* update ui tests
…ric (#11689)

* Fix giving a user access to a site is not possible when login is only numbers

Eg when login is 1234, the `login` var may actually be a number and then `.replace` won't work.

fixes #11680

* typo
Let plugins customize the system summary widget
…dependency (#11682)

Deactivating a plugin in case of a missing dependency is a bit risky. If just once a dependency is missing it would be directly deactivated. For example during an update we may run into an issue where a plugin dependency might be missing just for a short time frame. There may be also other edge cases where this might be the case. It would be better to instead trigger a notification only. I would show this notification only to super users but we do not have anything loaded at this time.

Any other ideas?
* Add more plugin links

* added missing templates

* consistent font size

* UI tests show the new messages
)

* Add possibility to ignore "no data recorded" screen for one hour

* update screens

* update wording
…imes (#11690)

* fix a bug in the join generator

* add another test case to make sure the outer table foreach still works when removing an item

* throw exception if table cannot be joined automatically
…ingDependencies must use numbered placeholders instead of multiple %s
…ies (#11683)

* fix #11681 make sure plugins in config.ini.php are sorted depending on dependencies

* added comment

* add missing tests
* update icon submodule

* fix UI tests

* fix system tests

* fix another UI test

* Fix system test
@mattab mattab added this to the 3.0.4 milestone May 15, 2017
@mattab mattab merged commit 7241195 into master May 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants