Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added missing method rowCount to db classes #11698

Merged
merged 1 commit into from May 15, 2017
Merged

Added missing method rowCount to db classes #11698

merged 1 commit into from May 15, 2017

Conversation

tsteur
Copy link
Member

@tsteur tsteur commented May 15, 2017

I just ran into an issue where I used the Db::rowCount method. This works fine when being in tracker mode and code works as the Db tracker has this method. However, when writing tests for it, it may use the regular Db during the tests which means the test fails. Therefore I added the missing methods to make the tests work.

Not sure if this is considered a bug, an enhancement, whether we should mention it in changelog or not.

@tsteur tsteur added the Needs Review PRs that need a code review label May 15, 2017
@tsteur tsteur added this to the 3.0.4 milestone May 15, 2017
@mattab mattab merged commit 210655c into 3.x-dev May 15, 2017
@mattab mattab deleted the rowcountmethod branch May 15, 2017 04:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review PRs that need a code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants