Make it possible to customize the No data available message shown in reports
#11693
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgiehl
added
the
c: Design / UI
sgiehl
force-pushed
the
customnodatamessage
branch
from
59a2531
to
6af41a7
Compare
tsteur
reviewed
May 12, 2017
| * Defaults to `CoreHome_ThereIsNoDataForThisReport` if not set | ||
| * | ||
| * @var string | ||
| */ |
There was a problem hiding this comment.
A comment would be very good / needed that this message will be printed raw and that user needs to escape output
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some reports it might make sense to explain why no data is available.
As doing that in the reports footer is not visible good enough it should be done directly in the no data message sometimes.