Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix giving a user access to a site is not possible when login is numeric #11689

Merged
merged 2 commits into from May 12, 2017
Merged

Fix giving a user access to a site is not possible when login is numeric #11689

merged 2 commits into from May 12, 2017

Conversation

tsteur
Copy link
Member

@tsteur tsteur commented May 11, 2017

Eg when login is 1234, the login var may actually be a number and then .replace won't work.

fixes #11680

I had a rough look for the other JS files there and should work for all other cases.

@tsteur
Fix giving a user access to a site is not possible when login is only…
ff046db 
… numbers

Eg when login is 1234, the `login` var may actually be a number and then `.replace` won't work.

fixes #11680
@tsteur tsteur added Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. labels May 11, 2017
@tsteur tsteur added this to the 3.0.4 milestone May 11, 2017
sgiehl
sgiehl requested changes May 12, 2017
View reviewed changes
Copy link
Member

@sgiehl sgiehl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a comment. After fixing that it should be good to merge.

plugins/UsersManager/angularjs/manage-user-access/manage-user-access.controller.js Outdated
@@ -42,7 +42,8 @@
}
};

this.setAccess = function (login, access) {
this.setAccess = function (login, access)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

guess you accidentally removed the {

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good find 👍

@sgiehl sgiehl removed the Needs Review PRs that need a code review label May 12, 2017
@mattab mattab merged commit 1d7c5cd into 3.x-dev May 12, 2017
@mattab mattab deleted the 11680 branch May 12, 2017 21:02
@mattab mattab added Bug For errors / faults / flaws / inconsistencies etc. and removed not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. labels May 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgiehl sgiehl sgiehl requested changes

Assignees
No one assigned
Labels
Bug For errors / faults / flaws / inconsistencies etc.
Projects
None yet
Milestone
3.0.4
Development

Successfully merging this pull request may close these issues.

Manage User Access Bug
3 participants
@tsteur @sgiehl @mattab