Add possibility to ignore "no data recorded" screen for one hour #11686
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsteur
added
Enhancement
sgiehl
reviewed
May 12, 2017
plugins/SitesManager/lang/en.json
Outdated
| @@ -76,6 +76,7 @@ | |||
| "SiteWithoutDataSetupTracking": "Please set up the %1$stracking code%2$s below into your website or mobile app if you haven't done already.", | |||
| "SiteWithoutDataMessageDisappears": "This message will disappear as soon as some data was tracked for this website.", | |||
| "SiteWithoutDataSetupGoals": "In the meantime, maybe you would like to %1$sset up some goals%2$s or learn more about the %3$sfeatures%4$s of Piwik in one of our %5$sguides%6$s or %7$sFAQs%8$s.", | |||
| "SiteWithoutDataIgnoreMessage": "Ignore this message for the next hour", | |||
There was a problem hiding this comment.
Instead of Ignore maybe Hide or Don't show sounds a bit less negative
|
Updated wording as suggested. Will update screens later and then merge. Think for now it's ok to not have it per site but can always change it later |
|
Nice & original idea 👍 If possible please make it "per site". Feel free to merge either way |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think it would be useful to ignore the "No data recorded" message at least for an hour.
When users install Piwik or want to try it, then they might not be able to track data immediately making it hard for them to get an idea what Piwik is or can do. By being able to ignore this message a user can "click around" and explore Piwik even when not having any data tracked.
It may also help in the future for cases like #11568 in case we decide to show the no data message even though log data purging is enabled. Then even though there is currently no data recorded, the user would be still able to access previously generated reports.
Feel free to suggest different wording.