Let plugins customize the system summary widget #11685
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsteur
added
c: Platform
sgiehl
approved these changes
May 12, 2017
There was a problem hiding this comment.
Event names and namespaces are fine I think.
Regarding the automatic component pickup: Maybe we should try to make a general decision here if we want to try to avoid (new) events where possible and use components instead. But that's nothing we need to decide for this PR. We can change it again later...
|
Yeah we would need those events either way, even with components so we can always change it later. Will merge it for now and can see later I'd say |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Plugins can now add more system summary items and filter existing system summary items.
I'm happy to change namespace if needed. I could have made this a component and pick up classes from an eg "SystemSumary" folder automatically but didn't want to overdo it for now as it is not such an essential feature and it is actually not really a core feature. Can do it though if needed. The events would be still needed even when they are in core so thought to keep it simple for now.