Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more plugin links #11684

Merged
merged 4 commits into from May 12, 2017
Merged

Add more plugin links #11684

merged 4 commits into from May 12, 2017

Conversation

tsteur
Copy link
Member

@tsteur tsteur commented May 10, 2017

In Overlay and Visitor Profile.

In Overlay it may not be fully visible depending on screen resolution as the left sidebar seems to be not scrollable (not sure if that is on purpose).

Also improved the code slightly as there was lots of duplicated code.

@tsteur tsteur added the Needs Review PRs that need a code review label May 10, 2017
@tsteur tsteur added this to the 3.0.4 milestone May 10, 2017
Copy link
Member

@sgiehl sgiehl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:

@sgiehl sgiehl added not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. and removed Needs Review PRs that need a code review labels May 12, 2017
@mattab mattab merged commit 716752b into 3.x-dev May 12, 2017
@mattab mattab deleted the hsrpluginlinks branch May 12, 2017 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants