Make sure plugins in config.ini.php are sorted depending on dependencies #11683
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsteur
added
c: Platform
tsteur
commented
May 9, 2017
| @@ -111,10 +114,73 @@ public function sortPlugins(array $plugins) | |||
| $otherPluginsToLoadAfterDefaultPlugins = array_diff($plugins, $defaultPluginsLoadedFirst); | |||
|
|
|||
| // sort by name to have a predictable order for those extra plugins | |||
| sort($otherPluginsToLoadAfterDefaultPlugins); | |||
| natcasesort($otherPluginsToLoadAfterDefaultPlugins); | |||
There was a problem hiding this comment.
We make sure to sort in natural order and to ignore lower / upper case
tsteur
commented
May 9, 2017
| $sorted = array(); | ||
| foreach ($otherPluginsToLoadAfterDefaultPlugins as $pluginName) { | ||
| $sorted = $this->sortRequiredPlugin($pluginName, $pluginJsonCache, $otherPluginsToLoadAfterDefaultPlugins, $sorted); | ||
| } |
There was a problem hiding this comment.
we cannot use classic usort here as it wouldn't sort correctly when "resolving" dependencies.
|
Tried to test this:
Is it supposed to work differently or my test procedure not correct? |
|
Your require looks wrong eg "1.0.0" is not a valid definition afaik. It definitely works see tests and also tested it manually. I would check the test procedure |
|
ok I'll check again. Which tests do you refer to? |
|
Forgot to commit the tests, just did |
Then the re-order works as expected. And with the now added test file, PR is perfect 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #11681
Please note that this will be only executed when activating or removing a plugin. So existing configs won't be changed. AFAIK there are not really any plugins making much use of this feature and this should be fine and we don't need to run an update to change existing configs. It will only affect in which order the
config/config.phpfiles are loaded in each plugin. The actual plugins are still loaded alphabetically by the platform (unless a plugin is required).