Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unload plugin instead of deactivating it when a plugin has a missing dependency #11682

Merged
merged 1 commit into from May 12, 2017

Conversation

tsteur
Copy link
Member

@tsteur tsteur commented May 9, 2017

Deactivating a plugin in case of a missing dependency is a bit risky. If just once a dependency is missing it would be directly deactivated. For example during an update we may run into an issue where a plugin dependency might be missing just for a short time frame. There may be also other edge cases where this might be the case. It would be better to instead trigger a notification only. I would show this notification only to super users but we do not have anything loaded at this time.

It also fixes an issue that the missing dependency was never shown in the notification because there was a %s missing.

Any other ideas?

…dependency

Deactivating a plugin in case of a missing dependency is a bit risky. If just once a dependency is missing it would be directly deactivated. For example during an update we may run into an issue where a plugin dependency might be missing just for a short time frame. There may be also other edge cases where this might be the case. It would be better to instead trigger a notification only. I would show this notification only to super users but we do not have anything loaded at this time.

Any other ideas?
@tsteur tsteur added the c: Platform For Matomo platform changes that aren't impacting any of our APIs but improve the core itself. label May 9, 2017
@tsteur tsteur added this to the 3.0.4 milestone May 9, 2017
@mattab
Copy link
Member

mattab commented May 12, 2017

New behavior is better for sure, does not change state of the platform in case of temporary or edge case issue 👍

@mattab mattab merged commit 1d6eba6 into 3.x-dev May 12, 2017
@sgiehl sgiehl deleted the requirepluginunload branch June 3, 2017 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: Platform For Matomo platform changes that aren't impacting any of our APIs but improve the core itself.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants