New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use PIWIK_DOCUMENT_ROOT instead of PIWIK_USER_PATH #11661
Conversation
Thanks for the PR! |
in UIAssetFetcher and StylesheetUIAssetMerger. Resolves matomo-org#11654, makes PIWIK_USER_PATH work again. Presumably. the paths were just mixed up.
30f89c5
to
a7fc4cb
Compare
@mattab thanks for your interest! 😄 To test this PR (this assumes a Debian-like filesystem):
In my case, I actually use an environment variable to set I assumed I'm the only one who doesn't know how to use this, but I just checked git history, and So I'll also write down what I could gather and understand about As @robocoder described at #11654 (comment), in an ideal world, piwik would have a The next best thing we have for this is
As I understand it, |
Imho this change sounds legit. |
@sgiehl could you quickly test this use case? |
My thoughts on this:
@sgiehl What do you think, did I miss something? If you see any use case, please give it a test! I just can't think of one. |
Haven't had some deeper thoughts on that before. Your possible use cases seem to be complete. Can't think of any other. |
Thanks! |
in UIAssetFetcher and StylesheetUIAssetMerger.
Resolves #11654, makes PIWIK_USER_PATH work again.
Presumably. the paths were just mixed up.