Add possibility to retrive the number of tracked pageviews in JS tracker #11655
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsteur
added
c: Platform
sgiehl
reviewed
Apr 28, 2017
CHANGELOG.md
Outdated
| @@ -10,6 +10,7 @@ The Product Changelog at **[piwik.org/changelog](http://piwik.org/changelog)** l | |||
| * A new event `Db.getActionReferenceColumnsByTable` has been added in case a plugin defines a custom log table which references data to the log_action table | |||
| * A new JavaScript tracker method `getPiwikUrl` has been added to retrieve the URL of where the Piwik instance is located | |||
| * A new JavaScript tracker method `getCurrentUrl` has been added to retrieve the current URL of the website. | |||
| * A new JavaScript tracker method `getNumTrackedPageViews` has been added to retrieve the number of tracked page views. | |||
There was a problem hiding this comment.
Won't that description be a bit confusing? Someone might think it makes it possible to retrieve the number of pageviews tracked within the visit. But actually it only returns the number of trackPageView calls done within the current loaded page.
|
@sgiehl I updated PR |
|
Haven't had time to check out the branch and test it. But code looks good and as tests are passing I guess it'd be fine to merge. |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Useful to detect eg if a page view has been already tracked or not.