@andocobo opened this Pull Request on April 27th 2017

This pull request replaces the user logins with user aliases in annotations. If a user cannot access the user alias of another user (eg. regular users trying to access a superuser's alias) then annotations fallback to using the user login.

It adds one new private method in the annotations controller to retrieve annotation related user info from the database.

@mattab commented on May 16th 2017 Member

Thanks for the pull request @andocobo

Could you please explain a bit why you think this change is useful and makes things better? It seems like a good idea but I can't yet explain why

@andocobo commented on May 17th 2017

Haha thanks Matthieu, 

This is my first attempt at contributing to an open source project, so I just went for an issue tagged 'easy pick'. To be honest, I don't know too much about why this is useful beyond what I read on the issue, it seems users are generally referred to by their alias in Piwik, but on annotations they were being referred to by their user names - it just makes it more consistent as far as I can see. 

Cheers,

Andrew Coe
Web designer and developer

 
Email:  andrew@quillstudios.com.au
Mobile:  0404 439 937
Web: www.quillstudios.com.au
                                  

On 17 May 2017 at 6:33:58 am, Matthieu Aubry (notifications@github.com) wrote:

Thanks for the pull request @andocobo

Could you please explain a bit why you think this change is useful and makes things better? It seems like a good idea but I can't yet explain why


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

@mattab commented on September 21st 2017 Member

Hi @andocobo
Would it be possible that you apply the changes suggested by @sgiehl in the review above? Looking forward to merging this...

@sgiehl commented on November 10th 2018 Member

Closing this one as user aliases are going to be removed

This Pull Request was closed on November 10th 2018
Powered by GitHub Issue Mirror