Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RowActions of SubdataTables (nodes) with many rows are disabled when limit selector is set to >=250 #11647

Closed
peterbo opened this issue Apr 25, 2017 · 3 comments
Labels
Bug For errors / faults / flaws / inconsistencies etc. c: Performance For when we could improve the performance / speed of Matomo. not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.

Comments

@peterbo
Copy link
Contributor

peterbo commented Apr 25, 2017

This is not reproducible on the demo since there is no SubdataTables hitting the set limit.

@tsteur
Copy link
Member

tsteur commented Apr 25, 2017

This is because of #11308 . We could maybe remove it once it is >= 500 but would need to test again re performance.

Problem is the more rows are shown the slower the UI gets and becomes eventually unusable. Like it will take even with only few hundred rows sometimes seconds to load and each scroll may take seconds. Ideally we would make it faster but it is not trivial I reckon or takes some time.

@mattab mattab added the c: Performance For when we could improve the performance / speed of Matomo. label May 8, 2017
@mattab mattab added this to the Priority Backlog (Help wanted) milestone May 8, 2017
@mattab mattab removed this from the Priority Backlog (Help wanted) milestone Jan 21, 2020
@mattab mattab added the Bug For errors / faults / flaws / inconsistencies etc. label Jan 21, 2020
@mattab
Copy link
Member

mattab commented Jan 21, 2020

@tsteur is this limitation still in place?

@tsteur
Copy link
Member

tsteur commented Jan 22, 2020

I think it's fixed. At least can't find it in the code anymore.

@tsteur tsteur closed this as completed Jan 22, 2020
@tsteur tsteur added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Jan 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug For errors / faults / flaws / inconsistencies etc. c: Performance For when we could improve the performance / speed of Matomo. not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Development

No branches or pull requests

3 participants