Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent removing page content when opening rowaction in widgetize mode #11644

Merged
merged 5 commits into from May 9, 2017
Merged

Prevent removing page content when opening rowaction in widgetize mode #11644

merged 5 commits into from May 9, 2017

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Apr 24, 2017

fixes #11359

@sgiehl sgiehl added Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. labels Apr 24, 2017
@sgiehl sgiehl added this to the 3.0.4 milestone Apr 24, 2017
@sgiehl sgiehl force-pushed the fixwidgetizerowactions branch 7 times, most recently from 3c49dc5 to 660011a Compare April 24, 2017 14:59
@tsteur
Copy link
Member

tsteur commented May 8, 2017

FYI: The actual bug is maybe here https://github.com/piwik/piwik/blob/3.0.4-b2/plugins/Dashboard/angularjs/dashboard/dashboard.directive.js#L96-L98 and it may be fixable by adding something like && newUrl.indexOf('moduleToWidgetize=Dashboard') === -1 or similar.

@sgiehl
Copy link
Member Author

sgiehl commented May 8, 2017

FYI: The actual bug is maybe here https://github.com/piwik/piwik/blob/3.0.4-b2/plugins/Dashboard/angularjs/dashboard/dashboard.directive.js#L96-L98 and it may be fixable by adding something like && newUrl.indexOf('moduleToWidgetize=Dashboard') === -1 or similar.

That is only one reason why the dashboard is been removed. But rowactions wouldn't work nevertheless. The history service and broadcast isn't initialized in widgetize mode

@sgiehl sgiehl force-pushed the fixwidgetizerowactions branch 2 times, most recently from 7c243dd to b3b1d65 Compare May 8, 2017 09:02
@mattab
Copy link
Member

mattab commented May 8, 2017

Works! can be merged once UI tests pass 👍

@sgiehl sgiehl force-pushed the fixwidgetizerowactions branch 4 times, most recently from e275ec2 to 480a659 Compare May 8, 2017 20:58
@mattab mattab merged commit defc546 into 3.x-dev May 9, 2017
@mattab mattab deleted the fixwidgetizerowactions branch May 9, 2017 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
3.0.4
3 participants
@sgiehl @tsteur @mattab