Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve updater to remove old files #11634

Merged
merged 1 commit into from May 8, 2017
Merged

Improve updater to remove old files #11634

merged 1 commit into from May 8, 2017

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Apr 19, 2017

Seems our update currently only checks the core directory, as well as all plugin directories. Thus changes in other directories like libs or vendor won't be checked.

fixes #11446

@sgiehl sgiehl added Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. labels Apr 19, 2017
@sgiehl sgiehl added this to the 3.0.4 milestone Apr 19, 2017
@sgiehl sgiehl requested a review from mattab April 19, 2017 19:00
@mattab
Copy link
Member

mattab commented May 8, 2017

👍

@mattab mattab merged commit 7020b47 into 3.x-dev May 8, 2017
@mattab mattab deleted the improveupdater branch May 8, 2017 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattab mattab Awaiting requested review from mattab

Assignees
No one assigned
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
3.0.4
Development

Successfully merging this pull request may close these issues.

Upgrader does not delete files that were removed in a newer Piwik version
2 participants
@sgiehl @mattab