Add plugin upload link to plugin admin #11630
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgiehl
added
Needs Review
mattab
reviewed
May 8, 2017
| @@ -25,6 +25,23 @@ | |||
|
|
|||
| var uninstallConfirmMessage = ''; | |||
|
|
|||
| $('.uploadPlugin').click(function (event) { | |||
There was a problem hiding this comment.
As this code is duplicated in plugins/Marketplace/angularjs/marketplace/marketplace.directive.js - could we refactor it in the new plugins/Marketplace/templates/uploadPluginDialog.twig ?
There was a problem hiding this comment.
We could maybe move that stuff into a new uploadPluginForm directive. Having the javascript directly in the template doesn't sound good to me.
There was a problem hiding this comment.
If easy to do then +1. Otherwise we can just add a comment in both files to note that the code is duplicated in the other file
|
Works 👍 just left a minor comment |
|
Moved the js into a new angular directive |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #11494