Improve message in plugin admin if a plugin is not found in filesystem #11629
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgiehl
added
c: Usability
tsteur
reviewed
May 8, 2017
| . $this->translator->translate('CorePluginsAdmin_PluginNotCompatibleWith', array($pluginName, self::getPiwikVersion())) | ||
| . '</strong><br/>' | ||
| . $suffix; | ||
| if (is_dir(PIWIK_INCLUDE_PATH . '/plugins/' . $pluginName)) { |
There was a problem hiding this comment.
Ideally we'd have a method for this in plugin manager but LGTM
There was a problem hiding this comment.
Actually there is already a method in plugin manager. So will change it to use that one instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently if a plugin does not exist on the filesystem the plugin shows "Plugin not compatible with Piwik X".
As mentioned in matomo-org/plugin-MarketingCampaignsReporting#10 (comment) this might be a bit missleading if the plugin is simply missing on filesystem.
With this PR plugin that are not found will have this message: