Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JavaScript Tracker: Add possibility to set URL parameters to ignore #11627

Closed
tsteur opened this issue Apr 19, 2017 · 2 comments · Fixed by #18031
Closed

JavaScript Tracker: Add possibility to set URL parameters to ignore #11627

tsteur opened this issue Apr 19, 2017 · 2 comments · Fixed by #18031
Assignees
@bx80
Labels
c: Platform For Matomo platform changes that aren't impacting any of our APIs but improve the core itself. c: Security For issues that make Matomo more secure. Please report issues through HackerOne and not in Github. Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc. Help wanted Beginner friendly issues or issues where we'd highly appreciate community's help and involvement.
Milestone
4.5.0

Comments

@tsteur
Copy link
Member

tsteur commented Apr 19, 2017

For a Piwik website or globally, it is already possible to exclude / ignore URL parameters. However, because the default request method is GET, ignored URL parameters would be still visible in the access log of the Piwik server.

Instead it would be great to be able to have a method in the JS tracker to ignore URL parameters like _paq.push(['setIgnoreUrlParams', 'sid', 'cid']);. Not sure what a good method name would be.

Because Piwik knows server side which parameters to ignore, we could also re-use this information in the JavaScript tracking code generator and automatically set this parameter.

In the tracker itself we already have a method removeUrlParameter() to remove a URL parameter so it should be not too hard to develop. We would add this probably to the method purify(url) where we already modify the URL based on configuration.
@tsteur tsteur added c: Platform For Matomo platform changes that aren't impacting any of our APIs but improve the core itself. c: Security For issues that make Matomo more secure. Please report issues through HackerOne and not in Github. Help wanted Beginner friendly issues or issues where we'd highly appreciate community's help and involvement. Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc. labels Apr 19, 2017
@mattab mattab added this to the Priority Backlog (Help wanted) milestone May 8, 2017
@ghost
Copy link

ghost commented Jul 31, 2017

@tsteur is this still open? If it is, I would like some guidance as it is going to be my first pr.

Thanks.

@mattab
Copy link
Member

mattab commented Sep 18, 2017

Hi @wehelie Yes, the issue is still opened. A pull request would be great 👍

@bx80 bx80 mentioned this issue Aug 14, 2021
Closed
10 tasks
@bx80 bx80 mentioned this issue Sep 19, 2021
Merged
10 tasks
@tsteur tsteur mentioned this issue Sep 20, 2021
Open
@justinvelluppillai justinvelluppillai changed the title Piwik JavaScript Tracker: Add possibility to set URL parameters to ignore JavaScript Tracker: Add possibility to set URL parameters to ignore Oct 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bx80 bx80

Labels
c: Platform For Matomo platform changes that aren't impacting any of our APIs but improve the core itself. c: Security For issues that make Matomo more secure. Please report issues through HackerOne and not in Github. Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc. Help wanted Beginner friendly issues or issues where we'd highly appreciate community's help and involvement.
Projects
None yet
Milestone
4.5.0
4 participants
@tsteur @mattab @justinvelluppillai @bx80