Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scrollbar should not display in Marketplace when update available #11620

Closed
Findus23 opened this issue Apr 18, 2017 · 1 comment · Fixed by #11621
Closed

Scrollbar should not display in Marketplace when update available #11620

Findus23 opened this issue Apr 18, 2017 · 1 comment · Fixed by #11621
Labels
c: Design / UI For issues that impact Matomo's user interface or the design overall.
Milestone
3.0.4

Comments

@Findus23
Copy link
Member

When there is an update label in marketplace, the overflow-x: hidden; in <li> causes chrome to show a scrollbar.
screenshot_20170418_105839

In Firefox it looks fine.
Replacing it with overflow: hidden; hides the scrollbar without moving anything else.

I'll create a pull request and we'll see what the UI tests shows.
@Findus23 Findus23 mentioned this issue Apr 18, 2017
Merged
@Findus23
Copy link
Member Author

Seems like the UI tests shows the same:
http://builds-artifacts.piwik.org/piwik/piwik/fix-scrollbar-in-marketplace/22877/Marketplace_superuser_invalid_license_key_entered.png

@sgiehl sgiehl added this to the 3.0.4 milestone Apr 21, 2017
@sgiehl sgiehl added the c: Design / UI For issues that impact Matomo's user interface or the design overall. label Apr 21, 2017
@mattab mattab changed the title Scrollbar in Marketplace when update available Scrollbar should not display in Marketplace when update available May 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: Design / UI For issues that impact Matomo's user interface or the design overall.
Projects
None yet
Milestone
3.0.4
Development

Successfully merging a pull request may close this issue.

hide scrollbar in Marketplace if update available matomo-org/matomo
2 participants
@sgiehl @Findus23