Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Grey border around flags in Datatable also affects other icons #11586

Closed
Findus23 opened this issue Apr 4, 2017 · 3 comments
Closed

Grey border around flags in Datatable also affects other icons #11586

Findus23 opened this issue Apr 4, 2017 · 3 comments
Labels
c: Design / UI For issues that impact Matomo's user interface or the design overall. Regression Indicates a feature used to work in a certain way but it no longer does even though it should.
Milestone
3.0.4

Comments

@Findus23
Copy link
Member

Findus23 commented Apr 4, 2017

Unfortunately I'm a few hours late for 3.0.3, but I just noticed it after updating my public piwik instance.
The grey border in the country overview also affects the other icons in the row:

screenshot_20170404_173505

It seems like the css selector introduced in 22f4a9f is a bit too broad as not only the span around the flag and text has the class label but also the whole tr.

Replacing it with .dataTable .label .label img { is ugly, but works.
@Findus23 Findus23 added the c: Design / UI For issues that impact Matomo's user interface or the design overall. label Apr 4, 2017
@Findus23 Findus23 changed the title Grey border around flags in Datatable also affect Grey border around flags in Datatable also affect other icons Apr 4, 2017
@Findus23 Findus23 changed the title Grey border around flags in Datatable also affect other icons Grey border around flags in Datatable also affects other icons Apr 4, 2017
@Findus23 Findus23 added the Regression Indicates a feature used to work in a certain way but it no longer does even though it should. label Apr 8, 2017
@Findus23
Copy link
Member Author

@mattab, do you have a idea how to solve this? I am missing the time to look into it at the moment, but I think this should be solved until the release of 3.0.4.

@mattab mattab added this to the 3.0.4 milestone Apr 26, 2017
@mattab
Copy link
Member

mattab commented Apr 26, 2017

Hi @Findus23 we'll investigate this for 3.0.4

@sgiehl
Copy link
Member

sgiehl commented Apr 29, 2017

I'll change it to use dataTable .label > img instead. Should solve the issue, as well

@sgiehl sgiehl closed this as completed in 9c00b6e Apr 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: Design / UI For issues that impact Matomo's user interface or the design overall. Regression Indicates a feature used to work in a certain way but it no longer does even though it should.
Projects
None yet
Milestone
3.0.4
Development

No branches or pull requests
3 participants
@mattab @sgiehl @Findus23