Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can we delete some fonts from the CpChart library to make Piwik release smaller? #11581

Closed
mattab opened this issue Apr 3, 2017 · 4 comments · Fixed by matomo-org/matomo-package#54
Assignees
Milestone

Comments

@mattab
Copy link
Member

mattab commented Apr 3, 2017

Follows up #11559

Can we delete some fonts from the CpChart library to make Piwik release smaller?

fonts

As our previous pChart library didn't have those fonts we're wondering:

  • Are these fonts used sometimes, in some graphs or for specific charsets / languages?
    • if so, when are these fonts used?
  • or can we delete them?
@mattab mattab added this to the 3.0.4 milestone Apr 3, 2017
@sgiehl
Copy link
Member

sgiehl commented Apr 10, 2017

Most fonts shouldn't be required as we aren't using them. CpChart uses GeosansLight.ttf as default, but should use our fonts as we explicitly set them.
So imho it should be safe to remove all fonts execpt of GeosansLight.ttf

sgiehl added a commit to matomo-org/matomo-package that referenced this issue Apr 18, 2017
@sgiehl sgiehl self-assigned this Apr 18, 2017
@aureq
Copy link

aureq commented Apr 18, 2017

@sgiehl Thanks for the PR.

I'm wondering what's the best way to approach this.

To remove the fonts, a custom code is required. But if later a removed font is used, some code in the packaging script will have to be amended again.
As opposed to just keeping the fonts and not changing the packaging script which would allow any developer/contributor to make use of these fonts.

Thoughts?

@sgiehl
Copy link
Member

sgiehl commented Apr 19, 2017

I wouldn't include them by default. If someone would like to use another font, than those already included in Piwik, he can provide the font within his plugin. And if we decide to use a new font, I wouldn't rely on a font included in a third party package, as that might change from version to version

@mattab
Copy link
Member Author

mattab commented May 8, 2017

As opposed to just keeping the fonts and not changing the packaging script which would allow any developer/contributor to make use of these fonts.

@aureq our goal with removing extra files is to keep the release ZIP/Tar.gz packages as small as possible and only include files which are needed to run Piwik. Our release package is already quite big (ZIP approximately 17M or 18M) , but as far as I can see all of the files are needed to run Piwik

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants