Intl LC_NUMERIC use fallback if locale en_US not installed #11571
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes "Error in the display of localized numbers" #10594
|
Good find Peter. Hope we can get this in upcoming 3.0.3. Maybe anyone can confirm this fix works? |
|
I tried this fix on a customer's instance where it also occured, without installing locale "en_US.UTF-8". It worked there. The fix will only fail on systems where neither en_US nor C is present (but I don't know if this can happen at all). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes "Error in the display of localized numbers" #10594 / #10596
Problem: On a few systems, only local locales are installed / enabled. Therefore, setting LC_NUMERIC to "en_US.UTF-8" silently fails and numerics are juggled in local manner (1,0 vs 1.0). This makes the NumberFormatter fail on those numbers.
The locale C/C.UTF-8/POSIX is present on nearly all systems, so we add those to the setlocale fallbacks.