Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace pChart library with CpChart #11559

Merged
merged 1 commit into from Apr 3, 2017
Merged

Replace pChart library with CpChart #11559

merged 1 commit into from Apr 3, 2017

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Mar 29, 2017

CpChart is another fork of pChart that was completely refactored and is compatible with all common PHP versions.

Just a few minor changes were required due to new class / method names.

fixes #11116

@sgiehl sgiehl added the Needs Review PRs that need a code review label Mar 29, 2017
@sgiehl sgiehl added this to the 3.0.3 milestone Mar 29, 2017
@sgiehl
Copy link
Member Author

sgiehl commented Mar 29, 2017

Note: We need to check if this bug might reappear:

The bug #4206 (GD with JIS-mapped Japanese Font Support) was fixed in this
commit: 516c13d
Changed files: class/pImage.class.php class/pDraw.class.php

Don't have GD with Japanese Font Support running. But can try to recompile GD later

Additionally we could check if we might exclude some files in build script as some files had been removed from the old library.

@mattab
Copy link
Member

mattab commented Mar 31, 2017

@sgiehl if you have some time after the other remaining issue (#6111) then +1 to try with the JIS-mapped Japanese Font Support, otherwise we could check and fix it afterwards in 3.0.4

@sgiehl
Copy link
Member Author

sgiehl commented Mar 31, 2017

Note: Recompiling GD wasn't enough, need to recompile PHP

@mattab mattab merged commit c79e156 into 3.x-dev Apr 3, 2017
@mattab mattab deleted the pchartcomposer branch April 3, 2017 17:44
@mattab mattab added the c: Platform For Matomo platform changes that aren't impacting any of our APIs but improve the core itself. label Apr 3, 2017
@mattab mattab mentioned this pull request Apr 3, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
c: Platform For Matomo platform changes that aren't impacting any of our APIs but improve the core itself. Needs Review PRs that need a code review
Projects
None yet
Milestone
3.0.3
Development

Successfully merging this pull request may close these issues.

Running the archive via cron will result often in errors "Illegal string offset 'XAxisDisplay' 'XAxisFormat' "
2 participants
@sgiehl @mattab