Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

In Scheduled reports, graphs display icons too big in the graph labels (for country, browser and OS) #11558

Closed
mattab opened this issue Mar 29, 2017 · 6 comments · Fixed by #11638
Closed

In Scheduled reports, graphs display icons too big in the graph labels (for country, browser and OS) #11558

mattab opened this issue Mar 29, 2017 · 6 comments · Fixed by #11638
Assignees
@sgiehl
Labels
Regression Indicates a feature used to work in a certain way but it no longer does even though it should.
Milestone
3.0.4

Comments

@mattab
Copy link
Member

mattab commented Mar 29, 2017

When creating a scheduled report, one can choose to include Graphs. The option is called "Display report tables and graphs". When adding reports like "Country", "Browsers". The generated report looks like below.

  • Expected: to see icons in the standard icon size (about 16 or 20 pixels)
  • Got: icons displayed much bigger

Countries + Region + City

countries

Operating systems

os

Browsers

browsers
@mattab mattab added the Regression Indicates a feature used to work in a certain way but it no longer does even though it should. label Mar 29, 2017
@mattab mattab added this to the 3.0.3 milestone Mar 29, 2017
@Findus23
Copy link
Member

@mattab, are you talking about the pdf or the html report?
I thought I have tested it.

@mattab
Copy link
Member Author

mattab commented Mar 29, 2017

Both have this problem as they both use the same ImageGraph API to generate those PNG graph

@Findus23
Copy link
Member

Ah, I have only tested the images in tables.
The problem is that the images are 48x48px large, but should be only displayed 16x16px large.

How are these images generated? They are inlined as data:image.

@sgiehl
Copy link
Member

sgiehl commented Mar 29, 2017

Guess somewhere in the ImageGraph plugin

@Findus23
Copy link
Member

Seems like there is no easy fix. Hardcoding getMaxLogoSize or getLogoSize only changes the spacing but not the image size. Seems like pChart always prints images in original size.

The documentation isn't extremely helpful ether:
http://wiki.pchart.net/doc.dataset.setseriepicture.html

@mattab mattab modified the milestones: 3.0.4, 3.0.3 Mar 29, 2017
@sgiehl
Copy link
Member

sgiehl commented Apr 18, 2017

Could we create resized duplicates of the images in tmp directory and use them?
Or we could try to adjust cPchart to make it possible to resize those images. Maybe it would get merged upstream if we propose a nice pull request...

@sgiehl sgiehl mentioned this issue Apr 19, 2017
Merged
@sgiehl sgiehl self-assigned this Apr 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sgiehl sgiehl

Labels
Regression Indicates a feature used to work in a certain way but it no longer does even though it should.
Projects
None yet
Milestone
3.0.4
Development

Successfully merging a pull request may close this issue.

Fix logo images sizes in scheduled reports matomo-org/matomo
3 participants
@mattab @sgiehl @Findus23