Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UIIntegrationTest_menu_apidisallowed UI test regressed #11549

Closed
mattab opened this issue Mar 28, 2017 · 1 comment · Fixed by #11633
Closed

UIIntegrationTest_menu_apidisallowed UI test regressed #11549

mattab opened this issue Mar 28, 2017 · 1 comment · Fixed by #11633
Assignees
@sgiehl
Labels
c: Tests & QA For issues related to automated tests or making it easier to QA & test issues. not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Regression Indicates a feature used to work in a certain way but it no longer does even though it should.
Milestone
3.0.4

Comments

@mattab
Copy link
Member

mattab commented Mar 28, 2017

The UI test UIIntegrationTest_menu_apidisallowed at: https://github.com/piwik/piwik/blob/3.x-dev/tests/UI/expected-screenshots/UIIntegrationTest_menu_apidisallowed.png

has regressed as it is expected to display instead: https://github.com/piwik/piwik/blob/2.17.0/tests/UI/expected-screenshots/UIIntegrationTest_menu_apidisallowed.png

Either the feature regressed or the UI test is not testing what's needed since Piwik 3.

Goal of this issue:

  • Make UI test test the feature as expected
  • Add another assertion in the UI test so we don't overwrite the file by mistake in the future. Could we add an assertion that screenshot should be less than 100 pixels high, or so?
@mattab mattab added c: Tests & QA For issues related to automated tests or making it easier to QA & test issues. Regression Indicates a feature used to work in a certain way but it no longer does even though it should. labels Mar 28, 2017
@mattab
Copy link
Member Author

mattab commented Mar 28, 2017

@mattab mattab added this to the 3.0.4 milestone Mar 28, 2017
@sgiehl sgiehl self-assigned this Apr 19, 2017
@sgiehl sgiehl mentioned this issue Apr 19, 2017
Merged
@mattab mattab added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label May 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sgiehl sgiehl

Labels
c: Tests & QA For issues related to automated tests or making it easier to QA & test issues. not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Regression Indicates a feature used to work in a certain way but it no longer does even though it should.
Projects
None yet
Milestone
3.0.4
Development

Successfully merging a pull request may close this issue.

Improve menu_apidisallowed UI test matomo-org/matomo
2 participants
@mattab @sgiehl