Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

All icons in own repo and included as a submodule #11548

Merged
merged 22 commits into from Mar 28, 2017

Conversation

mattab
Copy link
Member

@mattab mattab commented Mar 28, 2017

Re-creating #11383 with a few additional commits

refs #11370

Couldn't find a way to directly edit the other PR

Note: before merging we need to change the build script

wip in https://github.com/piwik/piwik-package/pull/52/files

@mattab mattab added this to the 3.0.3 milestone Mar 28, 2017
@mattab
Copy link
Member Author

mattab commented Mar 28, 2017

All tests fixed! (except #11550 which is un-related to this)

@mattab mattab mentioned this pull request Mar 28, 2017
38 tasks
@mattab mattab merged commit a0f0eb8 into 3.x-dev Mar 28, 2017
@mattab mattab deleted the Findus23-icons-as-a-submodule branch March 28, 2017 17:38
@mattab
Copy link
Member Author

mattab commented Mar 28, 2017

Congrats @Findus23 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants