Drop temporary table when no longer needed #11544
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I know the temporary table only exists during session, but problem is a possible error
PDOException: SQLSTATE[42S01]: Base table or view already exists: 1050 Table 'tmp_log_actions_to_keep' already exists
when logs are purged twice during a session.We could use
if not exists
when creating the table but then we would still have the entries from a previous "delete logs run" in there.I noticed this error in tests but it may also occur in a regular task schedule that purge logs is called twice if eg implemented by a plugin and by privacy manager etc.