Make it possible to disable Flatten feature for a given report #11529
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgiehl
added
Needs Review
sgiehl
added
Pull Request WIP
sgiehl
changed the title
sgiehl
added
Needs Review
mattab
reviewed
Mar 27, 2017
CHANGELOG.md
Outdated
| @@ -8,6 +8,7 @@ The Product Changelog at **[piwik.org/changelog](http://piwik.org/changelog)** l | |||
|
|
|||
| ### Breaking Changes | |||
| * New config setting `enable_plugin_upload` lets you enable uploading and installing a Piwik plugin ZIP file by a Super User. This used to be enabled by default, but it is now disabled by default now for security reasons. | |||
| * New property `Report::$supportsFlattening` lets you define if a report supports flattening (d)efaults to `true`). If set to `false` it will also set `ViewDataTable\Config::$show_flatten_table` to `false` | |||
There was a problem hiding this comment.
Indicate what "property" refers to. something like New Report class property or so
core/Plugin/Report.php
Outdated
| * @var bool | ||
| * @api | ||
| */ | ||
| protected $supportsFlattening = true; |
core/Plugin/Report.php
Outdated
| * @return bool | ||
| * @ignore | ||
| */ | ||
| public function supportsFlattening() |
|
👍 |
mattab
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently datatables are automatically flattened if the
flatparameter is given in the request. This cannot be prevented.It is now possible to set for a report if it supports flattening or not. This will also automatically be set to the view, so it's not required to set if for report and view as well.
This PR also disables the flattening for the referrer type report, as it doesn't work for that report.
fixes #11323