Premium Plugin Installer shows false error message after install #11516
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsteur
added
Needs Review
tsteur
commented
Mar 22, 2017
| continue; | ||
| } | ||
|
|
||
| if (!$this->pluginManager->isPluginInFilesystem($pluginName)) { |
There was a problem hiding this comment.
Prevent trying to install a plugin that is not available in the filesystem. We tried to install or activate all of them.
tsteur
commented
Mar 22, 2017
| @@ -502,7 +502,7 @@ public function activatePlugin($pluginName) | |||
| Piwik::postEvent('PluginManager.pluginActivated', array($pluginName)); | |||
| } | |||
|
|
|||
| protected function isPluginInFilesystem($pluginName) | |||
| public function isPluginInFilesystem($pluginName) | |||
There was a problem hiding this comment.
Actually needed this method in another plugin public as well so that's good :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #11512