Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Premium Plugin Installer shows false error message after install #11512

Closed
Findus23 opened this issue Mar 22, 2017 · 1 comment · Fixed by #11516
Closed

Premium Plugin Installer shows false error message after install #11512

Findus23 opened this issue Mar 22, 2017 · 1 comment · Fixed by #11516
Assignees
@tsteur
Labels
Bug For errors / faults / flaws / inconsistencies etc.
Milestone
3.0.3

Comments

@Findus23
Copy link
Member

I wanted to install a Premium Plugin (Search Engine Keywords Performance)

After adding the key to piwik, I got the suggestion to INSTALL PURCHASED PLUGINS, which opened a modal:
screenshot_20170322_133315

After clicking install I get the following errors (in production and local testing):
screenshot_20170322_080606

Plugin 'FormAnalytics' cannot be found in the filesystem in plugins/ directory.
Plugin 'RollUpReporting' cannot be found in the filesystem in plugins/ directory.
Plugin 'UsersFlow' cannot be found in the filesystem in plugins/ directory.
Plugin 'WhiteLabel' cannot be found in the filesystem in plugins/ directory.
Plugin 'Funnels' cannot be found in the filesystem in plugins/ directory.
Plugin 'AbTesting' cannot be found in the filesystem in plugins/ directory.
Plugin 'MediaAnalytics' cannot be found in the filesystem in plugins/ directory.
Plugin 'ActivityLog' cannot be found in the filesystem in plugins/ directory.
Some paid plugins were not installed successfully.

Everything works afterwards, but it seems a check in the installer is assuming one wants to install all premium plugins.
@tsteur tsteur added this to the 3.0.3 milestone Mar 22, 2017
@tsteur tsteur self-assigned this Mar 22, 2017
@tsteur tsteur added the Bug For errors / faults / flaws / inconsistencies etc. label Mar 22, 2017
@tsteur
Copy link
Member

tsteur commented Mar 22, 2017

Cheers, I heard of an error like this before and couldn't reproduce initially but seeing it again in the code it's quite obvious. Will issue a PR

tsteur added a commit that referenced this issue Mar 22, 2017
@tsteur
fix #11512 Premium Plugin Installer shows false error message after i…
d8e9dec 
…nstall
@tsteur tsteur mentioned this issue Mar 22, 2017
Merged
mattab pushed a commit that referenced this issue Mar 25, 2017
@tsteur @mattab
Premium Plugin Installer shows false error message after install (#11516
45f3ec3 
)

* fix #11512 Premium Plugin Installer shows false error message after install

* better handling when a plugin was installed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tsteur tsteur

Labels
Bug For errors / faults / flaws / inconsistencies etc.
Projects
None yet
Milestone
3.0.3
Development

Successfully merging a pull request may close this issue.

Premium Plugin Installer shows false error message after install matomo-org/matomo
2 participants
@tsteur @Findus23