New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cookie warning pops up in IE11 ShowModalDialog #11507
Comments
On IE11 and Win10 I'm not seeing a popup or warning on https://piwik.org
|
|
Ok thanks for the report. Do you maybe know how to fix this problem? |
@mattab We can break this down into two problems:
To fix #2, may be can can delay the cookie detection until the call to trackPageView? |
@mattab , we are planning to modify this in the following way, so we can validate this every time consistently. FYI - we also got the same issue popped up with IE and showmodal dialog combination. `
` Let us know if you have any concerns with this approach. Thanks in advance. |
@siva538 could you please open a pull request and not there what issue / use case does it help with? Thanks |
Sure @mattab . Will do. We ran into an issue with this when there were repeated popup messages as mentioned in screenshot on 3/22/17 above, and browser was asking to insert a cookie. However the reality was "navigatorAlias.cookieEnabled" is not supported in IE browser during "Show Modal Dialog". Reason for weightage is that there are still huge number of users across the globe using IE and this fix would help avoid the unnecessary popup's when Modal is used. Thank you. |
When the tracker is being initialized, configCookiesDisabled is set to true by default. When
hasCookies()
is called bydetectBroweserFeatures()
during initialization, this causes a cookie warning dialog to popup twice(each timenavigatorAlias.cookieEnabled
) is accessed. This occurs every time the modal dialog is opened.The text was updated successfully, but these errors were encountered: