Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

always use window.jQuery instead of $ in ui tests #11505

Merged
merged 1 commit into from Mar 20, 2017
Merged

Conversation

tsteur
Copy link
Member

@tsteur tsteur commented Mar 20, 2017

This is actually better this way instead of assigning $

Please issue pull request against the 3.x-dev branch only.

Piwik 2 is in LTS mode. This means we do not accept any pull request for 2.x except critical security bugs and major data loss bugs.

If you need to create a pull request for 2.x, then please also create the pull request against the 3.x-dev so we can merge both.

Happy hacking!

This is actually better this way instead of assigning $
@tsteur tsteur merged commit 56a4e91 into 3.x-dev Mar 20, 2017
@tsteur tsteur deleted the jqueryuitests branch March 20, 2017 23:46
@tsteur tsteur added this to the 3.0.3 milestone Mar 20, 2017
@tsteur tsteur added the c: Platform For Matomo platform changes that aren't impacting any of our APIs but improve the core itself. label Mar 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: Platform For Matomo platform changes that aren't impacting any of our APIs but improve the core itself.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant