Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve URI check when showing external pages for Overlays #11497

Merged
merged 1 commit into from Mar 21, 2017
Merged

Improve URI check when showing external pages for Overlays #11497

merged 1 commit into from Mar 21, 2017

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Mar 17, 2017

Current check was a bit weak, as is only compares if the URI that should be redirected to starts with the same hostname (after removing protocol).

With this changes the real hostnames will be compared.

@sgiehl sgiehl added c: Security For issues that make Matomo more secure. Please report issues through HackerOne and not in Github. Needs Review PRs that need a code review labels Mar 17, 2017
@sgiehl sgiehl added this to the 3.0.3 milestone Mar 17, 2017
@sgiehl sgiehl requested a review from mattab March 21, 2017 19:31
@mattab mattab merged commit c0534d8 into 3.x-dev Mar 21, 2017
@mattab mattab deleted the improveoverlayurlcheck branch March 21, 2017 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattab mattab Awaiting requested review from mattab

Assignees
No one assigned
Labels
c: Security For issues that make Matomo more secure. Please report issues through HackerOne and not in Github. Needs Review PRs that need a code review
Projects
None yet
Milestone
3.0.3
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sgiehl @mattab