Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Twilio SMSProvider #11487

Conversation

jamesbvaughan
Copy link

This branch adds a new SMS provider for Twilio. It is just two files, an image and Twilio.php, which is modelled after the existing SMS providers, Clockwork.php and ASPSMS.php.

The only SMSProvider method that I was unable to implement is getCreditLeft() because the Twilio API does not provide a way to check your current account balance.

@mattab mattab added this to the 3.0.4 milestone Mar 21, 2017
@mattab mattab added the Needs Review PRs that need a code review label Mar 21, 2017
@mattab
Copy link
Member

mattab commented Mar 21, 2017

Thanks for the PR! we will review in the next few weeks so it can be added to a release

@sgiehl
Copy link
Member

sgiehl commented Apr 9, 2017

@mattab a basic question regarding the sms providers: Do we want to add various new SMS providers to core? It should be easy to handle such new SMS providers in plugins instead.

@mattab
Copy link
Member

mattab commented Apr 11, 2017

Hi guys,

@sgiehl You're right, we now prefer that new SMS providers are added as part of a plugin published on the Marketplace. This way everybody benefits and we the core Piwik team, do not have to officially support all new SMS providers.

@jamesbvaughan we kindly request that the Twilio SMS integration is included in Piwik via the Marketplace. Otherwise your code should be good to go 👍

@mattab
Copy link
Member

mattab commented May 8, 2017

Hi @jamesbvaughan

The next steps to get this into Piwik users are:

Thank you for your contribution and we are looking forward to seeing it on the Marketplace 👍

@mattab mattab closed this May 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review PRs that need a code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants