Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Overlay bubbles on Firefox (and Opera Mini) #11485

Merged
merged 2 commits into from Mar 21, 2017

Conversation

phoob
Copy link
Contributor

@phoob phoob commented Mar 14, 2017

The previous css didn't work on firefox. Using transform: scale() combined with transform-origin is the recommended way to do it.

This also makes the placement of bubbles more consistent, makes it so we do not need to adjust offset top/left for zoomFactor.

The previous css didn't work on firefox (http://caniuse.com/#search=zoom). Using transform: scale() is the recommended way to do it according to
@sgiehl
Copy link
Member

sgiehl commented Mar 16, 2017

related to #11441

@phoob
Copy link
Contributor Author

phoob commented Mar 21, 2017

@sgiehl , @mattab – any thoughts on this? In my tests it solves #11441 ...

@mattab mattab added this to the 3.0.3 milestone Mar 21, 2017
@mattab
Copy link
Member

mattab commented Mar 21, 2017

Thanks @phoob it's much better 👍

Would you maybe be able to look into this issue which now shows up: #11509 - would be nice to show those bubbles on the the right so they are not hidden

@mattab mattab merged commit 907fdfe into matomo-org:3.x-dev Mar 21, 2017
@mattab mattab added not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Bug For errors / faults / flaws / inconsistencies etc. and removed not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. labels Mar 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug For errors / faults / flaws / inconsistencies etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants