Add possibility to select a specific frame within a page #11484
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eg `page.selectFrame('myFrameName');` and at the end of the test `page.selectMainFrame();`
What doesn't seem to work yet correctly is typing within the frame. I presume the position where the click should happen is not calculated correctly (it clicks before sending keys).
|
Now also supports |
|
Still a little issue is when selecting a frame within a frame, but planning on fixing this right now unless needed. |
|
Merging now as needed in 3.x-dev branch. Tests still succeed and do not affect any of our existing tests. |
|
If possible would be nice to document this new feature in https://developer.piwik.org/guides/tests-ui#capturing-only-a-part-of-the-page even very quick 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
eg
page.selectFrame('myFrameName');and at the end of the testpage.selectMainFrame();What doesn't seem to work yet correctly is typing within the frame. I presume the position where the click should happen is not calculated correctly (it clicks before sending keys).