Post current action in Template.beforeContent event #11481
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Be good to have this as well when wanting to restrict content to certain actions
|
LGTM. According to the issue, those events were added to make themeing easier. Not sure if they should be official API or not. But afaik they aren't mentioned anywhere in the docs. |
|
Yep they aren't mentioned and not even used. We could alternatively even remove them as I don't need them myself anymore. Merging for now and I presume it doesn't hurt for now to have them but also happy to remove them |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Be good to have this as well when wanting to restrict content to certain actions. Didn't add it to changelog since those events are not official APIs AFAIK