Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More secure / more random integer generation #11473

Merged
merged 1 commit into from Mar 18, 2017
Merged

More secure / more random integer generation #11473

merged 1 commit into from Mar 18, 2017

Conversation

tsteur
Copy link
Member

@tsteur tsteur commented Mar 10, 2017

See http://us2.php.net/manual/en/function.random-int.php : random_int — Generates cryptographically secure pseudo-random integers

@tsteur tsteur added c: Security For issues that make Matomo more secure. Please report issues through HackerOne and not in Github. Needs Review PRs that need a code review labels Mar 10, 2017
@tsteur tsteur added this to the 3.0.3 milestone Mar 10, 2017
@tsteur @sgiehl
More secure / more random integer generation
0178117 
See http://us2.php.net/manual/en/function.random-int.php : random_int — Generates cryptographically secure pseudo-random integers
@sgiehl
Copy link
Member

sgiehl commented Mar 17, 2017

LGTM

@tsteur tsteur merged commit 60f4a40 into 3.x-dev Mar 18, 2017
@tsteur tsteur deleted the randomint branch March 18, 2017 00:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
c: Security For issues that make Matomo more secure. Please report issues through HackerOne and not in Github. Needs Review PRs that need a code review
Projects
None yet
Milestone
3.0.3
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tsteur @sgiehl