Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Export as Image" exported image graph does not fit in the popover on displays > 2k #11464

Closed
cardinalacres opened this issue Mar 8, 2017 · 8 comments · Fixed by #11557
Closed

"Export as Image" exported image graph does not fit in the popover on displays > 2k #11464

cardinalacres opened this issue Mar 8, 2017 · 8 comments · Fixed by #11557
Assignees
@sgiehl
Labels
Bug For errors / faults / flaws / inconsistencies etc.
Milestone
3.0.3

Comments

@cardinalacres
Copy link

For widgets that display data as an image, when I use the "Export as Image" function the image produced is incorrectly scaled (only the upper left-hand corner of the image is visible). This appears to be a bug that was introduced with Piwik 3.0.0 (used to work in my install previously).

Attached is a screenshot showing the issue:

piwik_image_bug
@mattab
Copy link
Member

mattab commented Mar 21, 2017

Thanks for the report.

Which browser and Operating system do you use?

@cardinalacres
Copy link
Author

I see the same behavior on both Safari (v10.0.2) and Firefox (v52.0.1). This is on Mac OS X (or, I guess, MacOS these days) 10.12.2.

@Findus23
Copy link
Member

This issue reminds me of #9292 (comment) and #4594

@mattab
Copy link
Member

mattab commented Mar 21, 2017

Maybe this is easily fixable @sgiehl ?

@mattab mattab added this to the 3.0.3 milestone Mar 21, 2017
@sgiehl
Copy link
Member

sgiehl commented Mar 22, 2017

Can confirm that happens on displays > 2k only. Need to investigate

@sgiehl sgiehl self-assigned this Mar 22, 2017
@sgiehl sgiehl mentioned this issue Mar 29, 2017
Merged
@sgiehl
Copy link
Member

sgiehl commented Mar 29, 2017

I've created a pull request. Can anyone having a screen with a pixel ratio > 1 (like a retina display) approve this changes fix the problem?

@tsteur
Copy link
Member

tsteur commented Mar 29, 2017

looks good to me

image

@tsteur
Copy link
Member

tsteur commented Mar 29, 2017

and just to confirm this is with 3.x-dev branch

image

@mattab mattab changed the title "Export as Image" for widget images "Export as Image" exported image graph does not fit in the popover on displays > 2k Apr 3, 2017
@mattab mattab added the Bug For errors / faults / flaws / inconsistencies etc. label Apr 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sgiehl sgiehl

Labels
Bug For errors / faults / flaws / inconsistencies etc.
Projects
None yet
Milestone
3.0.3
Development

Successfully merging a pull request may close this issue.

Fix scaling of exported images matomo-org/matomo
5 participants
@tsteur @mattab @sgiehl @Findus23 @cardinalacres