Add system check for the hash() function #11455
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like the CI failed because of the screenshot test. Should I change anything in the PR to reflect that? |
|
You can update the expected UI test files by using the processed one from travis: http://builds-artifacts.piwik.org/piwik/piwik/3.x-dev/22539/processed/Installation_system_check.png |
|
@okay19 seems the screenshot is now no longer stored on GitLFS. Are you able to change that? If not maybe remove the commit again and I will update that afterwards |
|
@sgiehl Done. I haven't used Git LFS before, so I had to do a little research. |
|
awesome. Thanks for the update. Now all tests are passing 👍 |
|
Thanks @okay19 for your contributions recently! Would be awesome if you want to contribute more 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check during install if the hash() function exists in PHP. While enabled by default, it is possible to exclude this function at compile time by passing --disable-hash to configure. Fixes #11449.