Improves plugin list filters #11448
Merged
Improves plugin list filters #11448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgiehl
added
Needs Review
tsteur
reviewed
Mar 2, 2017
|
|
||
| if (isset($plugin['info']) && isset($plugin['info']['authors'])) { | ||
| foreach ($plugin['info']['authors'] as $author) { | ||
| if ($author['name'] == 'Piwik' || $author['name'] == 'InnoCraft') { |
There was a problem hiding this comment.
maybe good to check lowercase here as it may change in the future (shouldn't but never know)
|
Sounds good 👍 Either official or |
|
Excellent 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the available filters (All, Core, Third-Party) were kind of confusing, I tried to improve that by adding a new category 'Official', which will list all plugins that are developed by the Piwik team
Name of this category is still open for discussion.
Also we might consider to add a new category 'Premium', listing all plugins bought on Marketplace. Any opinions on that?
fixes #11145