Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrader does not delete files that were removed in a newer Piwik version #11446

Closed
daniel-barrows opened this issue Mar 2, 2017 · 6 comments · Fixed by #11634
Closed

Upgrader does not delete files that were removed in a newer Piwik version #11446

daniel-barrows opened this issue Mar 2, 2017 · 6 comments · Fixed by #11634
Assignees
@sgiehl
Labels
Regression Indicates a feature used to work in a certain way but it no longer does even though it should.
Milestone
3.0.4

Comments

@daniel-barrows
Copy link

Today, I updated Piwik, as installed via Softaculous.
I had Piwik version 3.0.1, and upgraded to version 3.0.2

I went from this page: https://example.com/piwik/index.php?module=CoreUpdater&action=newVersionAvailable, and chose an automated update, which took me to this page: https://example.com/piwik/index.php?module=CoreUpdater&action=oneClickUpdate,
which reported:

An error occurred
Your Piwik version 3.0.2 is up to date.

However, I appear to now be running 3.0.2 just fine. I ran the System Check and the only thing I see is another file integrity check issue which may have been pre-existing:

Files were found in your Piwik but we didn't expect them.
--> Please delete these files to prevent errors. <--

File to delete: error_log
File to delete: libs/jquery/jquery.smartbanner.js
File to delete: libs/jquery/MIT-LICENSE-smartbanner.txt
File to delete: libs/jquery/stylesheets/jquery.smartbanner.css

I'm not sure what the error message was about, but at the very least, this is a usability problem.
@chillivilli
Copy link

File to delete: libs/jquery/jquery.smartbanner.js
File to delete: libs/jquery/MIT-LICENSE-smartbanner.txt
File to delete: libs/jquery/stylesheets/jquery.smartbanner.cs

i have this too after update.

@lourdas
Copy link
Contributor

lourdas commented Mar 2, 2017

Same here. Before upgrading to 3.0.2 I had this kind of report and I manually deleted these extra files. After copying the files from 3.0.2, several tens of extra files reappeared. I manually deleted them again. Other than that, the application seems to work fine.

@daniel-barrows
Copy link
Author

daniel-barrows commented Mar 2, 2017 •
edited

I'm going to take a wild guess that this is a variation on #11107, but there is no message to the user indicating what the error was. I was only able to discover the file integrity issue by running a System Check. With no error report, the user is left to wonder if something is wrong with their installation even though everything seems fine.
For other users: If I'm correct, then your installation is fine, and you are encouraged to delete the excess files to prevent future errors (see #11129 (comment))

@mattab
Copy link
Member

mattab commented Mar 3, 2017

+1, we also experienced this. So there must be a bug in our updater where it should have deleted those files automatically yet it didn't.

@mattab mattab added the Regression Indicates a feature used to work in a certain way but it no longer does even though it should. label Mar 3, 2017
@gamanet
Copy link

gamanet commented Mar 15, 2017

I´m running a Debian GNU/Linux 8-Server with Piwik 3.0.2.

I´m using following repos:

deb https://debian.piwik.org/ piwik main
deb-src https://debian.piwik.org/ piwik main

After the upgrade to 3.0.2 (from 3.0.1) the systemcheck shows me following message:

_Die nachfolgenden Fehler könnten durch einen teilweise oder gänzlich fehlgeschlagenen Upload der Piwik-Dateien entstanden sein.
--> Versuche die Piwik-Dateien im BINARY-Modus neu hochzuladen. <--

Fehlende Datei: /usr/share/piwik//etc/apt/trusted.gpg.d/piwik-keyring-automatic.gpg_

In english it should read like:

_The following errors could have been caused by a partial or completely unsuccessful upload of the Piwik files.
-> Try to re-upload the Piwik files in BINARY mode. <-

Missing file: /usr/share/piwik//etc/apt/trusted.gpg.d/piwik-keyring-automatic.gpg_

The file "/etc/apt/trusted.gpg.d/piwik-keyring-automatic.gpg" exists on my server...
The file "/usr/share/piwik//etc/apt/trusted.gpg.d/piwik-keyring-automatic.gpg" doesn´t exists.
Not sure if it´s possible at all to have a file-/directory with "//" within name...

When running

php /usr/share/piwik/console diagnostics:run

i get that output:

_INFO [2017-03-15 09:16:58] Unable to test if mod_pagespeed is enabled: the request to http://unknown/usr/share/piwik/console?module=Installation&action=getEmptyPageForSystemCheck failed
File integrity: WARNING File integrity check failed and reported some errors. You should fix this issue and then refresh this page until it shows no error.

Directories were found in your Piwik but we didn't expect them.
--> Please delete these directories to prevent errors.
Memory limit: WARNING M
On a high traffic website, the archiving process may require more memory than currently allowed. If necessary, change the memory_limit directive in your php.ini file.
After making this change, restart your web server.
2 warnings detected_

But again no information which files were found...

@mattab mattab changed the title Upgrade error reported but seems fine Upgrader does not delete files that were removed in a newer Piwik version Mar 21, 2017
@mattab mattab modified the milestones: 3.0.3, 3.0.4 Mar 21, 2017
@mattab
Copy link
Member

mattab commented Mar 27, 2017

Moving out of 3.0.3 for now as we likely don't have time for 3.0.3 cc @sgiehl

@sgiehl sgiehl self-assigned this Apr 19, 2017
@sgiehl sgiehl mentioned this issue Apr 19, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sgiehl sgiehl

Labels
Regression Indicates a feature used to work in a certain way but it no longer does even though it should.
Projects
None yet
Milestone
3.0.4
Development

Successfully merging a pull request may close this issue.

Improve updater to remove old files matomo-org/matomo
6 participants
@gamanet @lourdas @mattab @sgiehl @chillivilli @daniel-barrows