Introduces new config setting to enabled plugin upload #11445
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgiehl
added
Needs Review
That's really good and saves a lot of explaining. I would likely just mention the name of the setting and the category like |
|
Added the info after the message. Now looks like this:
|
|
looks very nice |
|
very useful security improvement, and well done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Links for plugin upload will still be visible as before, but they will show a message instead.
Wasn't sure if we simply should remove the links when upload is disabled, but that would hide the feature completely, so I decided to show a message instead.
NOTE: Upload will be disabled by default
fixes #11329