Fix Clicking on the "Dashboard" top link hides all dashboard content #11429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also fixed the links in the admin menu that it wasn't possible to load the same page again. Eg go to General Settings => and then clicking on General Settings again will now reload the page. |
mattab
added
the
not-in-changelog
|
It's working well - @tsteur do you maybe have some resource to explain why this fixes the problem? is it maybe related to our broadcast or angularjs routing? |
|
Search for _self: https://docs.angularjs.org/guide/$location |
|
But is it really linking to dashboard now? The link is still to CoreHome/index, which might load the MultiSites Dashboard if the user configured that as default, or am I wrong? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #11386