Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clicking on the "Dashboard" top link hides all dashboard content #11386

Closed
mattab opened this issue Feb 21, 2017 · 2 comments · Fixed by #11429
Closed

Clicking on the "Dashboard" top link hides all dashboard content #11386

mattab opened this issue Feb 21, 2017 · 2 comments · Fixed by #11429
Assignees
@tsteur
Labels
Bug For errors / faults / flaws / inconsistencies etc.
Milestone
3.0.2

Comments

@mattab
Copy link
Member

mattab commented Feb 21, 2017

Reproduce:

  • Open http://demo.piwik.org/
  • The dashboard has loaded
  • In the top bar click the "Dashboard" link
  • Expected: the Dashboard reloads
  • Got: dashboard disappears

empty
@mattab mattab added the Bug For errors / faults / flaws / inconsistencies etc. label Feb 21, 2017
@mattab mattab added this to the 3.0.2 milestone Feb 21, 2017
@mattab mattab modified the milestones: 3.0.2, 3.0.3 Feb 24, 2017
@sgiehl
Copy link
Member

sgiehl commented Feb 26, 2017

The link currently points to index.php?module=CoreHome&action=index&....
This currently destroys the report area, as the url is the same base url as on every report page, but doesn't provide a hash part in the url. The change of the hash part (to nothing) triggers the history service.

What exactly would be the expected behaviour here? A hard link to the default dashboard of the current user? Or a link to the default page (which could also be the multisites dashboard,)

@mattab
Copy link
Member Author

mattab commented Feb 28, 2017

Or a link to the default page (which could also be the multisites dashboard,)

It would be I think confusing if it linked to Multisites. The "default page" can be reached by clicking on logo.

A hard link to the default dashboard of the current user?

Yes

@mattab mattab modified the milestones: 3.0.2, 3.0.3 Feb 28, 2017
tsteur added a commit that referenced this issue Feb 28, 2017
@tsteur
Fix Clicking on the "Dashboard" top link hides all dashboard content
8d63c99 
fixes #11386
@tsteur tsteur mentioned this issue Feb 28, 2017
Merged
@tsteur tsteur assigned tsteur and unassigned sgiehl Feb 28, 2017
mattab pushed a commit that referenced this issue Feb 28, 2017
@tsteur @mattab
Fix Clicking on the "Dashboard" top link hides all dashboard content (#…
d0b0c8d 
…11429)

* Fix Clicking on the "Dashboard" top link hides all dashboard content 

fixes #11386

* also fix links in admin menu
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tsteur tsteur

Labels
Bug For errors / faults / flaws / inconsistencies etc.
Projects
None yet
Milestone
3.0.2
Development

Successfully merging a pull request may close this issue.

Fix Clicking on the "Dashboard" top link hides all dashboard content matomo-org/matomo
3 participants
@tsteur @mattab @sgiehl