[WIP] Icons as a submodule #11383
Closed
[WIP] Icons as a submodule #11383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Seems like travis can't clone the submodule |
|
try using |
|
FYI @Findus23 renamed the repository to |
|
I have now changed the url in .gitmodules (I hope that's enough) |
Closed
mattab
added a commit
to matomo-org/matomo-package
that referenced
this pull request
Feb 21, 2017
Note: before merging we need to change the build script |
SystemTestshttps://travis-ci.org/piwik/piwik/jobs/203797459 IntegrationTestshttps://travis-ci.org/piwik/piwik/jobs/203797465:
source favicons
index.html in the flag-icon-css repo
UPDATE: they should be fixed in 978fc56 Unittestshttps://travis-ci.org/piwik/piwik/jobs/203797466 Solved in 955b838 Rest:
Not sure where the problem is. UI-Testsseem to fail because of the change in transparency and this errors (which shouldn't have to do with my change) http://builds-artifacts.piwik.org/piwik/piwik/3.x-dev/22428/UIIntegrationTest_admin_plugins.png |
|
I tried to merge the conflicts. we'll see which tests are failing now. |
|
There are some icons in piwik that are not in my repository (mostly because the sites are offline) I'll copy them over so the aren't missing for old sites. |
mattab
reviewed
Mar 25, 2017
.gitmodules
Outdated
| @@ -59,3 +59,6 @@ | |||
| branch = master | |||
|
|
|||
| # Note: do not add new plugin submodules here, but a few lines above | |||
| [submodule "plugins/Morpheus/icons"] | |||
There was a problem hiding this comment.
Could you move this above the comment, just below the log-analytics module
|
This looks great @Findus23 Review:
Then it looks good to be merged! 👍 |
I only saw one and fixed it
I'd prefer you to add them as I don't have git LFS installed. |
mattab
added a commit
to matomo-org/plugin-CustomDimensions
that referenced
this pull request
Mar 28, 2017
|
Let's continue in #11548 |
mattab
added a commit
to matomo-org/plugin-CustomDimensions
that referenced
this pull request
Mar 28, 2017
mattab
added a commit
that referenced
this pull request
Mar 28, 2017
mattab
added a commit
that referenced
this pull request
Mar 28, 2017
* add icons submodule * replace path * change submodule url * fix JSONTest * fix integration tests * update icon submodules * fix preg_match * fix remaining system tests * better match for non dist icon files * fix .gitmodules * update icon submodule * Fixed custom dimension test * Do not completely fail when GD not enabled * Fix http test + refactor checklist * Refactored the code into a method * Changed icon path refs #11383 * System tests * Update valid UI tests * Fix integration test
sgiehl
pushed a commit
to matomo-org/plugin-CustomVariables
that referenced
this pull request
Jun 18, 2020
* add icons submodule * replace path * change submodule url * fix JSONTest * fix integration tests * update icon submodules * fix preg_match * fix remaining system tests * better match for non dist icon files * fix .gitmodules * update icon submodule * Fixed custom dimension test * Do not completely fail when GD not enabled * Fix http test + refactor checklist * Refactored the code into a method * Changed icon path refs matomo-org/matomo#11383 * System tests * Update valid UI tests * Fix integration test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #11370
Let's see how many places I have missed.